Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base objects in with statements #3870

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix base objects in with statements #3870

merged 1 commit into from
Jun 4, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented May 30, 2024

This Pull Request changes the following:

  • Fix base objects in with statements

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels May 30, 2024
@raskad raskad added this to the v0.18.1 milestone May 30, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,771 50,771 0
Passed 42,985 42,986 +1
Ignored 1,411 1,411 0
Failed 6,375 6,374 -1
Panics 19 19 0
Conformance 84.66% 84.67% +0.00%
Fixed tests (1): 
test/language/expressions/call/with-base-obj.js (previously Failed)

@raskad raskad requested a review from a team May 30, 2024 01:41
@raskad raskad marked this pull request as ready for review May 30, 2024 01:41
jedel1043
jedel1043 approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jedel1043 jedel1043 requested a review from a team June 1, 2024 17:24
nekevss
nekevss approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@nekevss nekevss added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 4419e6d Jun 4, 2024
13 checks passed
@jedel1043 jedel1043 deleted the fix-with-base-object branch June 4, 2024 04:14
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @nekevss